Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct time axis #26

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Correct time axis #26

merged 2 commits into from
Sep 24, 2021

Conversation

pag1pag
Copy link

@pag1pag pag1pag commented Sep 24, 2021

Add:

  • pylint -> prettier code (code rate 6.5/10)
  • mypy -> code easier to read (but not yet very useful)

Fix:

  • change in qtplaskin.timeformatter.py -> use a simpler function, in agreement with set_major_formatter.
    - Could be even more simplified, by not using a class TimeFormatter at all (but could also be less readable)

@erwanp erwanp merged commit b06a835 into erwanp:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwanp erwanp erwanp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pag1pag @erwanp