Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing of atomic composition in excited species A(*) #25

Merged
merged 1 commit into from
May 26, 2021

Conversation

erwanp
Copy link
Owner

@erwanp erwanp commented May 13, 2021

No description provided.

@erwanp erwanp added this to the 1.1.3 milestone May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #25 (43d857e) into master (0ca9bd9) will increase coverage by 0.71%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   46.87%   47.58%   +0.71%     
==========================================
  Files          13       13              
  Lines         576      580       +4     
==========================================
+ Hits          270      276       +6     
+ Misses        306      304       -2     
Impacted Files Coverage Δ
test/test_parsing_atoms.py 95.23% <95.23%> (ø)
qtplaskin/database.py 89.28% <100.00%> (+5.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca9bd9...43d857e. Read the comment docs.

@erwanp erwanp force-pushed the fix/parse-atoms-in-excited-states branch from 8f0c250 to 43d857e Compare May 13, 2021 14:22
@erwanp erwanp requested a review from maillardj May 13, 2021 14:34
@erwanp erwanp merged commit a495043 into master May 26, 2021
@erwanp erwanp deleted the fix/parse-atoms-in-excited-states branch May 26, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant