Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in Pandas when reading files with 'Infinity' #6

Closed
4 tasks done
githeap opened this issue Aug 26, 2019 · 2 comments
Closed
4 tasks done

bug in Pandas when reading files with 'Infinity' #6

githeap opened this issue Aug 26, 2019 · 2 comments
Assignees
Labels

Comments

@githeap
Copy link
Collaborator

githeap commented Aug 26, 2019

By default this fork of QtPlaskin uses pandas.read_csv function to speed up data loading.
ZdPlaskin is a Fortran code and uses "Infinity" to represent inf values in output text files.
There is an issue #10065 in Pandas with reading such files. Pandas read_csv interprets "Infinity" as a string, not a floating point value.

Untill the issue #10065 is not resolved in Pandas, as a workaround, we fallback to old (slower) data import for datasets containing "Infinity"s. a5b1559

Update: Add a very straightforward fix to Pandas #28181. Hope, someone will come up with smarter solution.

githeap added a commit that referenced this issue Aug 26, 2019
@githeap githeap self-assigned this Aug 29, 2019
@githeap githeap added the bug label Aug 29, 2019
@erwanp
Copy link
Owner

erwanp commented Aug 29, 2019

Well done on getting it approved!

@erwanp erwanp mentioned this issue Sep 19, 2019
githeap added a commit that referenced this issue Jan 3, 2021
@githeap
Copy link
Collaborator Author

githeap commented Jan 3, 2021

pandas-dev/pandas#28181 was merged in Pandas 1.0

@githeap githeap closed this as completed Jan 3, 2021
githeap referenced this issue Jan 3, 2021
# Conflicts:
#	qtplaskin/modeldata.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants