Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Create publishing action #32

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Create publishing action #32

merged 1 commit into from
Jan 14, 2021

Conversation

ChrisChinchilla
Copy link
Collaborator

I started by addressing #28 and then digging in their docs realised we could publish new versions to both marketplaces with one action. But I appear to have lost some access levels @jdkato and can't create the required secrets needed in this action, or I can share the openvsx one with you…

@jdkato
Copy link
Member

jdkato commented Nov 26, 2020

I think you have full access to this repo, but it seems that the action requires a token generated from dev.azure.com? If so, I think I'll have to generate that.

@ChrisChinchilla
Copy link
Collaborator Author

@jdkato I do not. If I look at one of my own repos, I can go to settings and create repo-level secrets (which is what we need for the action), but not in this repo. GH permissions are really irritating, I likely need admin access if I don't have that already. If I do, it must be an org level thing, and I'll have to get you to do it instead.

@jdkato
Copy link
Member

jdkato commented Dec 6, 2020

I made you an admin. The GitHub UI says that you only gain the ability to add collaborators, but let me know if it worked.

@ChrisChinchilla
Copy link
Collaborator Author

@jdkato I can confirm I now have access to that section, so will get back to this PR asap.

@ChrisChinchilla ChrisChinchilla self-assigned this Dec 10, 2020
@ChrisChinchilla ChrisChinchilla marked this pull request as ready for review December 28, 2020 15:52
@ChrisChinchilla
Copy link
Collaborator Author

OK @jdkato I have added a secret for the Open VSX part, following the steps here - https://github.com/HaaLeo/publish-vscode-extension#readme

This should work, once my submission to claim ownership of the 'errata-ai' publisher name is approved for both of us.

For the official VSC store, I think you will need to follow the instructions here - https://github.com/HaaLeo/publish-vscode-extension#visual-studio-marketplace as I do not know what your PAT is for the store, but if you add it as a secret to this repo, that should work fine, I think, we'll see on next merge to master with a new tag.

@ChrisChinchilla
Copy link
Collaborator Author

@jdkato our namespace is approved, so this also means that the open vex part should now work automatically - EclipseFdn/open-vsx.org#275 (comment)

@jdkato
Copy link
Member

jdkato commented Jan 13, 2021

Thanks for setting this up.

I added the VS_MARKETPLACE_TOKEN, so this is ready to merge?

@ChrisChinchilla
Copy link
Collaborator Author

@jdkato I think so, we won't really know if it has worked until the next tag really.

@ChrisChinchilla ChrisChinchilla merged commit 36e9f36 into master Jan 14, 2021
@ChrisChinchilla ChrisChinchilla deleted the publishing-action branch March 19, 2021 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants