-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Erlang/OTP 26 + Elixir 1.14 on top Windows #191
Test Erlang/OTP 26 + Elixir 1.14 on top Windows #191
Conversation
Can we add 26.0 on Ubuntu to the mix? |
This pull request's for a specific issue, related to Windows and the linked GitHub issue. I'll change the title so it's not misleading, but yeah, we'll eventually had 26.0 to the tests. Pretty sure you can already use it when consuming the action, though. Are you experiencing any issues? |
I see. That compatibility is not maintained by the action, though. It just reports on it. OTP-26.0 is available from Hex.pm builds, for Ubuntu-20.04: https://builds.hex.pm/builds/otp/ubuntu-20.04/builds.txt Elixir 1.14.4 for OTP-26 is also available from Hex.pm builds: https://builds.hex.pm/builds/elixir/builds.txt |
Works for me: https://github.com/paulo-ferraz-oliveira/setup-beam-example/actions/runs/5002581961/jobs/8962708174#step:3:26. It is possible, though, we're using different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I separate cmd
and args
everywhere to make it easier to spot.
I also separate options
to its own variable for similar reasons (and because I wanted to experiment with the differences between Linux and Windows)...
I add a few new debugging options for our own future comfort.
Now that the action is reported to work on top of Elixir 1.14.5 for Windows, I'm moving this away from draft (hopefully the tests will also show it working properly). |
Force pushed to resolve conflict. This'll probably not move the feature further than that, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
Let's keep this open until building OTP 26 on Windows is possible.This seems to be in a mergeable state, now. Just need to make sure CI is issue-less.(1)
Hopefully fixes #189.
(1) Yeah, there's some confusion with
master
v.main
but I'll change everything to main.