[dap] improve dap startup and shutdown #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TheGeorge
commented
Feb 16, 2021
•
TheGeorge
commented
- shutdown dap and send events when project node goes down
- ensure, that we don't double monitor nodes
- shutdown project node when we get a disconnect request
- add config for cookie and startup timeout
TheGeorge
force-pushed
the
dap_cookie
branch
from
16b2474 to
800b8ee
Compare
|
it made sense to merge #915 and this one into one PR. |
TheGeorge
changed the title
|
@robertoaloi can you take a look? |
robertoaloi
approved these changes
Feb 20, 2021
| % connect and monitore project node | ||
| case els_distribution_server:wait_connect_and_monitor(Node, Timeout) of | ||
| ok -> inject_dap_agent(Node); | ||
| _ -> stop_debugger() |
There was a problem hiding this comment.
This could be just error, right?
There was a problem hiding this comment.
In this case we could crash, and let the supervisor handle the error behavior.
| timer:sleep(?WAIT_INTERVAL), | ||
| case connect_and_monitor(Node) of | ||
| ok -> | ||
| ok; | ||
| error -> | ||
| ?LOG_WARNING( "Trying to connect to node ~p (~p/~p)" | ||
| , [Node, ?WAIT_ATTEMPTS - Attempts + 1, ?WAIT_ATTEMPTS]), | ||
| wait_connect_and_monitor(Node, Attempts - 1) | ||
| , [Node, MaxAttempts - Attempts + 1, MaxAttempts]), |
There was a problem hiding this comment.
Out of curiosity, why do we need this change?
There was a problem hiding this comment.
I added a config parameter, that makes the connection timeout configurable. This change displays the connection attemps correctly (e.g. 12/30)
| % connect and monitore project node | ||
| case els_distribution_server:wait_connect_and_monitor(Node, Timeout) of | ||
| ok -> inject_dap_agent(Node); | ||
| _ -> stop_debugger() |
There was a problem hiding this comment.
This could just be error, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.