Skip to content

Commit

Permalink
[#754] Return the original io:getopts/0 values in noop_group_leader.
Browse files Browse the repository at this point in the history
Otherwise the shell_docs:render does not receive an encoding, and causes a crash
when requesting information for hover requests.

Closes #754
  • Loading branch information
alanz committed Oct 30, 2020
1 parent 7dcbad1 commit 6f10f9b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/els_sup.erl
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ noop_group_leader() ->
lager:info("noop_group_leader got [message=~p]", [Message]),
case Message of
{io_request, From, ReplyAs, getopts} ->
From ! {io_reply, ReplyAs, []};
%% We need to pass the underlying io opts, otherwise shell_docs does
%% not know which encoding to use. See #754
From ! {io_reply, ReplyAs, io:getopts()};
{io_request, From, ReplyAs, _} ->
From ! {io_reply, ReplyAs, ok};
_ ->
Expand Down

0 comments on commit 6f10f9b

Please sign in to comment.