Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glk_stream_open_file should silently return null on missing read file #4

Closed
erkyrath opened this issue Nov 25, 2017 · 3 comments
Closed

glk_stream_open_file should silently return null on missing read file #4

erkyrath opened this issue Nov 25, 2017 · 3 comments

Comments

@erkyrath
Copy link
Owner

This change will apply to all my interpreters. Keeping this open until they're all fixed. (Unless I decide to post duplicate bugs, but we'll see how long it takes me.)
@erkyrath erkyrath changed the title glk_stream_open_file() should silently return null on missing read file glk_stream_open_file should silently return null on missing read file Nov 25, 2017
@erkyrath erkyrath mentioned this issue Nov 26, 2017
Closed
@erkyrath
Copy link
Owner Author

Fixed in glkote.

curiousdannii added a commit to curiousdannii/remglk that referenced this issue Aug 4, 2020
@curiousdannii
glk_stream_open_file should not error when trying to read missing file
eccd4d7 
See erkyrath/glk-dev#6
erkyrath/cheapglk#4
@curiousdannii curiousdannii mentioned this issue Aug 4, 2020
Merged
erkyrath pushed a commit that referenced this issue Aug 8, 2020
According to recent spec discussion, we only display an error on
3846c87 
missing files for write/append mode. In read mode, we return silently.

#4
@erkyrath erkyrath closed this as completed Aug 8, 2020
@curiousdannii
Copy link

curiousdannii commented Aug 8, 2020 •
edited
Loading

Thank you for also fixing the glk_fileref_create_by_prompt issue, I wasn't sure what to do with that.

glkterm does need the fixes, if you're still maintaining it.

@erkyrath erkyrath mentioned this issue Aug 8, 2020
Open
@erkyrath
Copy link
Owner Author

erkyrath commented Aug 8, 2020

glkterm... may be maintained again some time in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@curiousdannii @erkyrath