Skip to content

Commit

Permalink
undid PR #93 to fix #142. thanks, @halt-hammerzeit!
Browse files Browse the repository at this point in the history
  • Loading branch information
@erikras
erikras committed Aug 27, 2015
1 parent b040bc6 commit 94f69f7
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions webpack/webpack-dev-server.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ var WebpackDevServer = require('webpack-dev-server'),
headers: {"Access-Control-Allow-Origin": "*"},
stats: {colors: true}
},
compiler = webpack(config, function(err, stats){
var json = stats.toJson();
if (json.errors.length)
console.error(json.errors[0])
}),
webpackDevServer = new WebpackDevServer(compiler, serverOptions);

webpackDevServer.listen(port, host, function() {
Expand Down

5 comments on commit 94f69f7

@quirinpa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes code splitting issues for me

@soda29
Copy link

@soda29 soda29 commented on 94f69f7 Aug 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and what with compiler variable in line 17?

@catamphetamine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it should have been

compiler = webpack(config)

@erikras
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. I changed it about a minute later. :-)

@soda29
Copy link

@soda29 soda29 commented on 94f69f7 Aug 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! =)

Please sign in to comment.