sp_QuickieStore: Correct UTC offsets #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erikdarlingdata As requested. Must've been my fault. Guess I synced with the wrong branch before forking. |
|
More tests. I think this is the final proof that the code works. Docker time zone "Pacific/Midway" (UTC -11:00) Docker time zone "Canada/Newfoundland" (UTC -03:30, but I think it's their summer time) Docker time zone "ETC/UTC" (UTC +00:00) Docker time zone "Pacific/Guam" (UTC +10:00) |
erikdarlingdata
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #449 by switching to use
SWITCHOFFSETrather than our old arithmetic tricks with@utc_offset_minutes. I'll spin up some Docker containers on different time zones to provide more evidence that this is working. For now, I just have this screenshot from my British Summer Time instance.Notice that the _UTC columns are unchanged. This is intentional and correct.