Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix Windows build after PR 2698 #2705

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Conversation

canepat
Copy link
Member

@canepat canepat commented Feb 9, 2025

No description provided.

@canepat canepat marked this pull request as ready for review February 9, 2025 14:49
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Feb 9, 2025
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 50.67%. Comparing base (9d01284) to head (4760aa0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
silkworm/db/datastore/kvdb/cursor_iterator.hpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2705      +/-   ##
==========================================
- Coverage   50.69%   50.67%   -0.02%     
==========================================
  Files         809      809              
  Lines       53139    53145       +6     
  Branches     8274     8274              
==========================================
- Hits        26937    26930       -7     
- Misses      23866    23874       +8     
- Partials     2336     2341       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canepat canepat requested a review from battlmonstr February 9, 2025 16:00
@canepat canepat merged commit d153f7a into master Feb 9, 2025
16 of 17 checks passed
@canepat canepat deleted the ci/fix_windows_build_after_2698 branch February 9, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant