capi: block execution commits after state batch has been flushed #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canepat
force-pushed
the
node_fix_execution_state_counters
branch
from
92f25b8 to
fc1316f
Compare
node: fix batch size computation in db buffer node: avoid caching read values in db buffer
node: change RWTxnUnmanaged to allow commit and abort
api: change batch flush policy from gas to size node: fix empty element in call traces
node: fix state batch size computation for account code and storage node: sort storage locations to insert ordered data into db node: fix unmanaged r/w txn destruction add unit tests
canepat
force-pushed
the
node_fix_execution_state_counters
branch
from
fe93c80 to
5d01cde
Compare
canepat
changed the title
canepat
added
the
maintenance
JacekGlen
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes related to block execution API implementation:
Moreover, some other things as well:
All these changes have been made in the process of reaching full binary data compatibility between Erigon and Erigon+Silkworm, step by step, over a long sequence of comparative tests: that's why this PR required quite a long time to be finalised.