Proper Caplin's subscription listen #9821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Subscription system
Sentinel has a time-based subscription system, which means that
subscriptions persists only until a specific point in time is reached.
```go=
func (sub *GossipSubscription) OverwriteSubscriptionExpiry(expiry time.Time) {
sub.expiration.Store(expiry)
}
```
All gossip topics are joined which means we can publish at all times,
but not all gossip topics are listened to, which means we are not
listening for all topic's subscriptions. calling the function above will
keep make Caplin listen to that topic until `expiry`is reached. once
rached, the listener will be closed **but we can still publish** if we
set the expiry, so that now we need to listen again, then we will revive
the subscription.
|
Kakkarrot
pushed a commit
to covalenthq/erigon
that referenced
this pull request
Apr 17, 2024
Cherry pic PR erigontech#9734 into the release Co-authored-by: Giulio rebuffo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick PR #9734 into the release