support --sync.loop.block.limit in newHeads notification
#9684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somnathb1
approved these changes
Mar 12, 2024
mriccobene
pushed a commit
to mriccobene/erigon
that referenced
this pull request
Mar 13, 2024
…h#9684) now, if `--sync.loop.block.limit=10` erigon may send all headers - because doesn't check jump end. Added: - check that headerNum < `finishStageAfterSync` (it was missed) - log amount of sent headers - iterate over canonical markers instead of headers - it's cheaper and don't need additional hash check related to erigontech#8721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now, if
--sync.loop.block.limit=10erigon may send all headers - because doesn't check jump end. Added:finishStageAfterSync(it was missed)related to #8721