Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure EIP-4844 parameters for Gnosis #8464

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Configure EIP-4844 parameters for Gnosis #8464

merged 8 commits into from
Oct 13, 2023

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis requested a review from somnathb1 October 13, 2023 08:12
somnathb1
somnathb1 reviewed Oct 13, 2023
View reviewed changes
core/state_transition.go Outdated Show resolved Hide resolved
erigon-lib/chain/chain_config.go Outdated Show resolved Hide resolved
params/chainspecs/gnosis.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have them configured for ethereum as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my mind it's OK to leave then nil for Ethereum and rely instead on default values in chain.Config.GetMinBlobGasPrice() and the like.

@yperbasis yperbasis merged commit b60642f into devel Oct 13, 2023
@yperbasis yperbasis deleted the config_blob_params branch October 13, 2023 09:43
@VBulikov VBulikov mentioned this pull request Feb 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somnathb1 somnathb1 somnathb1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yperbasis @somnathb1