Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some hive tests #8331

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Fix some hive tests #8331

merged 4 commits into from
Oct 1, 2023

Conversation

somnathb1
Copy link
Contributor

Changes:
Reorder some Engine API invalid checks to be closer to specs/hive tests
Move the Engine API direct method names to interfaces

@somnathb1 somnathb1 changed the title Refactor + fix some hive tests Refactor Engine API and Fix some hive tests Sep 30, 2023
@somnathb1 somnathb1 requested a review from yperbasis September 30, 2023 12:13
Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why move some methods to a different file? The old way when all EngineServer methods live in engine_server.go looks logical to me. Could you put them back please.

N.B. Ideally semantic changes should be decoupled from cosmetic reshuffling (though sometimes it's impractical to do that). Otherwise it's difficult to review.

@somnathb1 somnathb1 changed the title Refactor Engine API and Fix some hive tests Fix some hive tests Oct 1, 2023
@somnathb1
Copy link
Contributor Author

Why move some methods to a different file? The old way when all EngineServer methods live in engine_server.go looks logical to me. Could you put them back please.

N.B. Ideally semantic changes should be decoupled from cosmetic reshuffling (though sometimes it's impractical to do that). Otherwise it's difficult to review.

Well, the logic part of the implementation of the interface methods actually lie within engine_server.go. The old way here, makes things a tad more difficult to make changes to.
The methods now moved to interfaces.go would more likely not be changed at all, so it makes sense to separate them.
However, I have put the methods back. @yperbasis

@somnathb1 somnathb1 requested a review from yperbasis October 1, 2023 10:11
@yperbasis yperbasis merged commit 6dd7d8f into devel Oct 1, 2023
@yperbasis yperbasis deleted the hive-fix-som branch October 1, 2023 10:42
@VBulikov VBulikov mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants