ethstats: Fix nil ptr #13794
Merged
ethstats: Fix nil ptr #13794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
approved these changes
Feb 13, 2025
somnathb1
added a commit
that referenced
this pull request
Feb 13, 2025
Fixes an issue on startaup:
```
2025-02-13 13:03:15.102
[INFO] [02-13|09:03:15.101] head updated hash=0x67f34674738b118c66deac95137e9e4c0f47411aed142bda9b7a452537e29ee3 number=396 age=0 execution=3.025816ms mgas/s=0.00 average mgas/s=0.00 commit=696.106µs alloc=41.2MB sys=87.1MB
2025-02-13 13:03:18.152
panic: runtime error: invalid memory address or nil pointer dereference
2025-02-13 13:03:18.152
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2409c54]
2025-02-13 13:03:18.152
goroutine 154 [running]:
2025-02-13 13:03:18.152
github.com/erigontech/erigon/core/types.(*Block).Hash(...)
2025-02-13 13:03:18.152
github.com/erigontech/erigon/core/types/block.go:1483
2025-02-13 13:03:18.152
github.com/erigontech/erigon/ethstats.(*Service).reportHistory(0xc000174160, 0xc0018ae978, {0xc001e464e0, 0x32, 0x1b?})
2025-02-13 13:03:18.152
github.com/erigontech/erigon/ethstats/ethstats.go:618 +0x274
2025-02-13 13:03:18.152
github.com/erigontech/erigon/ethstats.(*Service).loop(0xc000174160)
2025-02-13 13:03:18.152
github.com/erigontech/erigon/ethstats/ethstats.go:240 +0x752
2025-02-13 13:03:18.152
created by github.com/erigontech/erigon/ethstats.(*Service).Start in goroutine 1
2025-02-13 13:03:18.152
github.com/erigontech/erigon/ethstats/ethstats.go:162 +0x4f
```
somnathb1
added a commit
that referenced
this pull request
Feb 14, 2025
Fixes an issue on startaup:
```
2025-02-13 13:03:15.102
[INFO] [02-13|09:03:15.101] head updated hash=0x67f34674738b118c66deac95137e9e4c0f47411aed142bda9b7a452537e29ee3 number=396 age=0 execution=3.025816ms mgas/s=0.00 average mgas/s=0.00 commit=696.106µs alloc=41.2MB sys=87.1MB
2025-02-13 13:03:18.152
panic: runtime error: invalid memory address or nil pointer dereference
2025-02-13 13:03:18.152
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2409c54]
2025-02-13 13:03:18.152
goroutine 154 [running]:
2025-02-13 13:03:18.152
github.com/erigontech/erigon/core/types.(*Block).Hash(...)
2025-02-13 13:03:18.152
github.com/erigontech/erigon/core/types/block.go:1483
2025-02-13 13:03:18.152
github.com/erigontech/erigon/ethstats.(*Service).reportHistory(0xc000174160, 0xc0018ae978, {0xc001e464e0, 0x32, 0x1b?})
2025-02-13 13:03:18.152
github.com/erigontech/erigon/ethstats/ethstats.go:618 +0x274
2025-02-13 13:03:18.152
github.com/erigontech/erigon/ethstats.(*Service).loop(0xc000174160)
2025-02-13 13:03:18.152
github.com/erigontech/erigon/ethstats/ethstats.go:240 +0x752
2025-02-13 13:03:18.152
created by github.com/erigontech/erigon/ethstats.(*Service).Start in goroutine 1
2025-02-13 13:03:18.152
github.com/erigontech/erigon/ethstats/ethstats.go:162 +0x4f
```
Cherry-pick #13794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue on startaup: