Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining Hive Cancun Test Failures #9407

Closed
spencer-tb opened this issue Feb 8, 2024 · 0 comments · Fixed by #9413
Closed

Remaining Hive Cancun Test Failures #9407

spencer-tb opened this issue Feb 8, 2024 · 0 comments · Fixed by #9413
Assignees

Comments

@spencer-tb
Copy link

Description

I'm tagging the last few failures here for the hive cancun tests. Specifically from the engine-cancun and pyspec simulators.

engine-cancun simulator

We only have 1 failure left from the test: Invalid PayloadAttributes, Missing BeaconRoot, Syncing=True.
This test checks the response from a fcuV3, where the beacon root is missing from the payload attributes, whilst syncing.

Erigon returns with {"code":-38003,"message":"Invalid payload attributes"}, however after the execution apis spec update in ethereum/execution-apis#498, we don't expect an error. Note the following from the PR:

Update fcu v1 spec to explicitly state that payloadAttributes validations and build process can only be run after forkchoiceState is processed and only if the head is VALID implying that if a client is SYNCING no payloadAttributes validations are run.

As we are syncing, no payload attribute validations should be run.

Steps to reproduce

Using the latest version of hive run the following command:

./hive --sim ethereum/engine --client erigon --client-file configs/cancun.yaml --docker.output --sim.limit engine-cancun/"Invalid PayloadAttributes, Missing BeaconRoot, Syncing=True"

pyspec simulator

There are 3 remaining (all related failures). These are best highlighted here: https://hivecancun.ethdevops.io/suite.html?suiteid=1707388139-34eee8e57a911404b68034c9872d72ed.json&suitename=pyspec#

They are variations of the parameterized test: test_invalid_pre_fork_block_with_blob_fields, where we check that the last Shanghai block before Cancun is correctly invalidated. Here we are sending an engine_newPayloadV2 with blob fields.

Erigon returns with:
{"status":"INVALID","validationError":"invalid block hash","latestValidHash":null,"CriticalError":null}
but we expect the invalid parameter error code{"code":-32602,"message":"Invalid parameters" ....

Steps to reproduce

Using the latest version of hive run the following command:

./hive --sim ethereum/pyspec --client erigon --client-file configs/cancun.yaml --docker.output --sim.limit pyspec/"test_invalid_pre_fork_block_with_blob_fields"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants