Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixin/implementing stuff from feedback #41

Merged
merged 1 commit into from
Nov 18, 2023
Merged

fixin/implementing stuff from feedback #41

merged 1 commit into from
Nov 18, 2023

Conversation

dvovk
Copy link
Member

@dvovk dvovk commented Nov 18, 2023

Fixing/implementing stuff from Daniel's feedback

  • “can't read response: stream error: stream ID 1; CANCEL.“ The error is printed constantly while running “make run-self-signed” on macOS. It uses a lot of CPU and eventually the terminal eats all system memory.
  • Peers: The peers summary is crammed to the left in a very narrow column:
  • Peers: Looking at the peers summary the active peers count jumps between 0 and actual peers count on each refresh.
  • Peers: In peer details replace string “Bytes In” with just “In”, “Bytes Out” -> “Out”.
  • Close button color shouldn’t be red. Red is usually reserved for destructive actions (like “Clear all data”).
  • Peers: There should be a way to navigate from the peers list to the peers summary page. When I click on the “active peers”, it opens the table on top of the summary. The summary is partially visible below:
  1. The “Back” button doesn’t go back, it should go back to the “Peers” page.
  2. Pressing “Peers” in the left menu does nothing. It should close the table and show the summary.
  3. The table should occupy 100% of the space. There’s no need to show the summary parts below it.
  • Peers: Split “Network usage” column in 2 separate columns: “In” and “Out”. Adding the 2 together makes little physical sense (it is like summing up your salary and your rent together 😀 ).
  • Peers: Display a total in/out network usage. What’s the best place in UI for it? I suggest to have it either as a separate row above the table, or on the peers summary page whatever is easier.
  • Peers: Show “rate in”, “rate out” columns in MB/sec (or KB/sec). This should be measured as a moving average over the last minute.
  • Added sorting for peers table
  • Added banners which will show you whether you are connected to internet and to a erigon node

@dvovk dvovk merged commit 5230fcb into main Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant