Avoid heap allocation for small strings in sqlite3_bind_text #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll run tests and get back to you. |
|
I'm seeing a failing test case when the string is zero-length. I put in a quickie fix for that and I'm going to run the EFCore test suite, which is much more comprehensive. |
ericsink
added a commit
that referenced
this pull request
Feb 11, 2021
|
After my tweak for the empty string case, this passes all my tests and the EF Core tests. |
|
@ericsink Is there a follow-up issue for modifying this method to call SQLite's UTF-16 method instead of relying on managed code to do the conversion? |
|
@sharwell Not yet. Sorry I'm a bit slow on responses -- I'm swamped with another project today. Feel free to log such an issue. I don't plan any objections, although I do want to make sure I understand exactly how the underlying C API works. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ericsink For your consideration. Not sure how tests work here. Would def like to ensure this actually gets coverage. Thanks!