Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csr slice bug fix #90

Merged
merged 1 commit into from
Jun 13, 2017
Merged

csr slice bug fix #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/mxnet/sparse_ndarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,8 @@ def _slice(self, start, stop):
assert(stype == 'csr'), "_slice for " + str(stype) + " not implemented yet"
warnings.warn('slicing SparseNDArray is not efficient', RuntimeWarning)
shape = list(self.shape)
stop = shape[0] if stop is None else stop
start = 0 if start is None else start
shape[0] = stop - start
handle = _new_alloc_handle(self.storage_type, tuple(shape), self.context,
True, self.dtype, self.aux_types)
Expand Down
2 changes: 2 additions & 0 deletions tests/python/unittest/test_sparse_ndarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ def check_sparse_nd_csr_slice(shape):
start = rnd.randint(0, shape[0] - 1)
end = rnd.randint(start + 1, shape[0])
assert same(A[start:end].asnumpy(), A2[start:end])
assert same(A[start:].asnumpy(), A2[start:])
assert same(A[:end].asnumpy(), A2[:end])

shape = (rnd.randint(2, 10), rnd.randint(1, 10))
check_sparse_nd_csr_slice(shape)
Expand Down