Fixed socket address parsing for IPv6 #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satsen
added a commit
to Satergo/Satergo
that referenced
this pull request
Aug 13, 2022
Note: The Ergo node does not support IPv6 declaredAddress yet, I have submitted a pull request (ergoplatform/ergo#1806)
kushti
approved these changes
Aug 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was splitting the declaredAddress based on colons. This works with IPv4 socket addresses, but IPv6 socket addresses are formatted like this:
[2345:0425:2CA1:0000:0000:0567:5673:23b5]:9030.There are colons in the IP itself. I changed the code to cut the string based on the last colon.
(No wonder there are no IPv6 nodes found on ergonodes.net, you could not even declare one before this fix..)