Eip4 update #214
Merged
Eip4 update #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslesarenko
requested changes
Feb 20, 2023
lib-impl/src/main/java/org/ergoplatform/appkit/impl/OutBoxBuilderImpl.scala
Outdated
Show resolved
Hide resolved
aslesarenko
requested changes
Feb 20, 2023
lib-impl/src/main/java/org/ergoplatform/appkit/impl/OutBoxBuilderImpl.scala
Outdated
Show resolved
Hide resolved
aslesarenko
requested changes
Feb 20, 2023
aslesarenko
requested changes
Feb 20, 2023
| } | ||
| if(token.getMintingBoxR9 != null){ | ||
| throw new IllegalArgumentException("R9 cannot exist without R7") | ||
| } |
There was a problem hiding this comment.
That is a lot of nesting. It would be easier to add nulls to _registers and then just check finally that _registers don't have nulls. And throw otherwise. This will be easier to cover with tests.
There was a problem hiding this comment.
This has some logic error which fails tests, please see how I changed implementation to remove nested statements.
aslesarenko
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to allow collection token minting in updated eip4
Must be merged with master 5.0 since develop currently has breaking changes