Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic builder of ErgoValue for Scala #185

Merged
merged 7 commits into from
Aug 30, 2022
Merged

Conversation

aslesarenko
Copy link
Member

Closes #184
Implementation of generic builder to create ErgoValue instances with valid Java types from Scala.

@aslesarenko aslesarenko marked this pull request as ready for review July 22, 2022 21:45
@MrStahlfelge MrStahlfelge self-assigned this Jul 27, 2022
Copy link
Member

@MrStahlfelge MrStahlfelge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for feedback by CheeseEnthusiast if this covers all his use cases.

Only small improvement suggestion is adding a hint to ErgoValue and ErgoValueBuilder that the other builder class for the other language exists.

@K-Singh
Copy link
Contributor

K-Singh commented Aug 30, 2022

Yeah this just about fixes most of the problems I faced. I found ways to do it manually but this is much much simpler and makes using ErgoValue's from Scala a lot easier.

@aslesarenko aslesarenko merged commit 2ba674d into develop Aug 30, 2022
@aslesarenko aslesarenko deleted the ergovalue-builder branch August 31, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement generic builder of ErgoValue for Scala
3 participants