Check tokens balance before TX signing #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v4.0.6 (with Sigma v4.0.5 and ergo-wallet v4.0.20)
Release v4.0.7 (with Sigma v4.0.5 and ergo-wallet v4.0.23)
Release v4.0.8 (with Sigma v4.0.5 and ergo-wallet v4.0.24)
Release v4.0.9 (with Sigma v4.0.5 and ergo-wallet v4.0.27)
Release v4.0.10 (with Sigma v4.0.5 and ergo-wallet v4.0.27)
…reduceTransaction
MrStahlfelge
approved these changes
Jul 13, 2022
lib-api/src/main/java/org/ergoplatform/appkit/UnsignedTransaction.java
Outdated
Show resolved
Hide resolved
appkit/src/test/scala/org/ergoplatform/appkit/AppkitProvingInterpreterSpec.scala
Show resolved
Hide resolved
aslesarenko
changed the title
MrStahlfelge
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token balance is checked by AppkitProvingInterpreter.reduceTransaction. When inputs/outputs balance is changed, then the difference is checked against explicitly requested token burning and possible token minting.
This check is independent from how UnsignedErgoLikeTransaction is created and it serves as sanity/security check against possible bugs in transaction building.