EIP-29 attachment implementation #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tRegisters wrong order of returned list
aslesarenko
requested changes
Mar 30, 2022
appkit/src/test/scala/org/ergoplatform/appkit/Eip29AttachmentTest.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/ergoplatform/appkit/Eip29Attachment.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/ergoplatform/appkit/Eip29Attachment.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/ergoplatform/appkit/Eip29Attachment.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/ergoplatform/appkit/Eip29Attachment.java
Outdated
Show resolved
Hide resolved
lib-impl/src/main/java/org/ergoplatform/appkit/impl/Eip29AttachmentBuilder.java
Outdated
Show resolved
Hide resolved
lib-impl/src/main/java/org/ergoplatform/appkit/impl/OutBoxBuilderImpl.scala
Show resolved
Hide resolved
aslesarenko
requested changes
Apr 5, 2022
lib-impl/src/main/java/org/ergoplatform/appkit/impl/Eip29AttachmentBuilder.java
Outdated
Show resolved
Hide resolved
|
Added a unit test demonstrating the type declaration problem, please take a look. |
|
The test is fixed but intErgoValue.getValue() still returns an Integer but declares to return scala.Int - so the declaration is still not correct and the test fix works because it is going through a Scala layer. The test itself is not the problem, it was just my demonstration. We've got to make the following decision: should the ErgoValue<> contain Scala types or not?
|
# Conflicts: # appkit/src/test/scala/org/ergoplatform/appkit/TxBuilderSpec.scala
aslesarenko
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation for current version of ergoplatform/eips#58