New Accessor Methods #140
Merged
New Accessor Methods #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…act, InputBox, OutBox, and their associated implicit classes
aslesarenko
requested changes
Feb 16, 2022
common/src/main/java/org/ergoplatform/appkit/impl/ErgoScriptContract.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/ergoplatform/appkit/impl/ErgoScriptContract.java
Show resolved
Hide resolved
common/src/main/java/org/ergoplatform/appkit/impl/ErgoTreeContract.java
Outdated
Show resolved
Hide resolved
lib-impl/src/main/java/org/ergoplatform/appkit/impl/OutBoxImpl.scala
Outdated
Show resolved
Hide resolved
|
Added the the changes you requested @aslesarenko |
aslesarenko
approved these changes
Feb 21, 2022
| @@ -270,7 +270,7 @@ class TxBuilderSpec extends PropSpec with Matchers | |||
| val recipient = address | |||
|
|
|||
| val amountToSend = 1000000 | |||
| val pkContract = new ErgoTreeContract(recipient.getErgoAddress.script) | |||
| val pkContract = new ErgoTreeContract(recipient.getErgoAddress.script, recipient.getNetworkType) | |||
There was a problem hiding this comment.
Looks like now a new constructor can be added with Address parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created additional accessor methods in InputBox, OutBox, ErgoContract, and UnsignedTransaction along with their Impl versions. Also replaced token function in OutBox with getTokens() and passed in additional variables when building UnsignedTransactions