Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement Expressions\NoErrorSuppressionRule #113

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

localheinz
Copy link
Member

This PR

  • implements an Expressions\NoErrorSuppressionRule, which reports an error when @ is used to suppress errors

@localheinz localheinz self-assigned this Sep 5, 2019
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #113 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #113      +/-   ##
============================================
+ Coverage        84%   84.19%   +0.19%     
- Complexity       95       97       +2     
============================================
  Files            16       17       +1     
  Lines           325      329       +4     
============================================
+ Hits            273      277       +4     
  Misses           52       52
Impacted Files Coverage Δ Complexity Δ
src/Expressions/NoErrorSuppressionRule.php 100% <100%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd632ae...0cecd9d. Read the comment docs.

@localheinz localheinz force-pushed the feature/error-suppression branch from 7ca5edb to 6c34205 Compare September 5, 2019 21:46
@localheinz localheinz force-pushed the feature/error-suppression branch from 6c34205 to 0cecd9d Compare September 5, 2019 21:50
@localheinz localheinz merged commit d92c567 into master Sep 5, 2019
@localheinz localheinz deleted the feature/error-suppression branch September 5, 2019 22:08
@localheinz localheinz mentioned this pull request Sep 5, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant