Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Infer private property type from constructor #106

Merged

Conversation

localheinz
Copy link
Member

This PR

  • infers private property types from constructors

@localheinz localheinz self-assigned this Sep 4, 2019
@localheinz localheinz force-pushed the feature/infer-private-property-type-from-constructor branch from 53ac194 to cc8c9bf Compare September 4, 2019 20:09
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #106   +/-   ##
=========================================
  Coverage     83.89%   83.89%           
  Complexity       82       82           
=========================================
  Files            13       13           
  Lines           298      298           
=========================================
  Hits            250      250           
  Misses           48       48
Impacted Files Coverage Δ Complexity Δ
src/Classes/FinalRule.php 88.88% <ø> (ø) 17 <0> (ø) ⬇️
src/Classes/NoExtendsRule.php 84.61% <ø> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd848a...cc8c9bf. Read the comment docs.

@localheinz localheinz merged commit 4a7e12f into master Sep 4, 2019
@localheinz localheinz deleted the feature/infer-private-property-type-from-constructor branch September 4, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant