Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow installations on PHP8 #265

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Allow installations on PHP8 #265

merged 1 commit into from
Dec 8, 2020

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Dec 8, 2020

No description provided.

@codecov
Copy link

codecov bot commented Dec 8, 2020 •
edited
Loading

Codecov Report

Merging #265 (4993f29) into main (82c5f18) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #265   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity         8         8           
===========================================
  Files              2         2           
  Lines             24        24           
===========================================
  Hits              24        24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c5f18...4993f29. Read the comment docs.

@localheinz localheinz self-assigned this Dec 8, 2020
@localheinz localheinz force-pushed the php8 branch 2 times, most recently from 037eb9a to 97b6d54 Compare December 8, 2020 15:57
@localheinz localheinz removed the merge label Dec 8, 2020
localheinz
localheinz approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz localheinz merged commit b5bd1c6 into ergebnis:main Dec 8, 2020
@localheinz
Copy link
Member

Thank you, @Nyholm!

@Nyholm Nyholm deleted the php8 branch December 8, 2020 16:10
@Nyholm
Copy link
Contributor Author

Nyholm commented Dec 8, 2020

Thank you

@nikolaposa nikolaposa mentioned this pull request Dec 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localheinz localheinz localheinz approved these changes

@ergebnis-bot ergebnis-bot Awaiting requested review from ergebnis-bot ergebnis-bot is a code owner

Assignees

@localheinz localheinz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @localheinz