Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buoyancy Fix & WRFInput Rebalance #2162

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

AMLattanzi
Copy link
Collaborator

This PR completes two things.

  1. It adds a flag to the WRFInput initialization that allows users to rebalance HSE given Theta_d & q_v. This uses the Newton iters function to obtain rho_d rather than taking from the wrfinput file.
  2. It corrects issues in the make buoyancy routine

The mods to make buoyancy are based upon the following derivation (this is for using \theta_d)
image

A similar derivation may be obtained when using T directly and that essentially differs by the 1/\gamma on the P'/P term. In all buoyancy routines we have neglected the P'/P term so that was continued here.

@AMLattanzi AMLattanzi requested a review from asalmgren February 28, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant