Release 28.3 #1018
Merged
Release 28.3 #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: goblins
bug 2968 stealing creates a message
Wird vom Parser in LERNE umgewandelt!
https://bugs.eressea.de/view.php?id=2972 Flammenschwertern haben nur den Zauberschaden gemacht, keine normale Attacke.
Schaden von Flammenschwertern
spobjp should never be null
Bugfix Zeitdehnung
add stubs for spell tests. spells that cannot find targets should cost nothing when targets resist, pay spell costs
they haven't been used since 2017
additional testing
add a test to prove that unit size doesn't matter for maintenance.
* handle notfound and resist * remove chance from vigour reduction full tests for unit, ship, building TBD
there was a copy of clibs/strings in util that caused conflicts.
I wish I was able to mock select_familiar and test that it gets called with force, not level.
this would have benefitted from mocks, but uses knowledge of select_familiar implementation details instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.