Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate fakeit::Prototype<...>::MemberType parsing #299

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

seva-deriv
Copy link
Contributor

Add template keyword as required by C++ standard

@coveralls
Copy link

coveralls commented Nov 18, 2022

Coverage Status

Coverage remained the same at 99.925% when pulling 5a48e74 on seva-deriv:master into 96f193e on eranpeer:dev-2.3.1.

@FranckRJ FranckRJ changed the base branch from master to dev-2.3.1 November 18, 2022 11:47
@FranckRJ FranckRJ added this to the 2.3.1 milestone Nov 18, 2022
@FranckRJ
Copy link
Collaborator

Thanks for the fix. Just out of curiosity, did you had any issue before adding that keyword, and if so with which compiler / what kind of code ?

And also, usually we don't change what's inside the single_header directory, it's only generated once before a release. If you can revert these changes it would be better but it's not a big deal anyway I can do it myself.

@seva-deriv
Copy link
Contributor Author

seva-deriv commented Nov 18, 2022

OK, I'll revert.
I faced the compilation error on clang/clang-cl 14.0.1. But the use case was not straightforward. It was in "disabled" context in expression like if constexpr (eval_to_false) { <HERE> }.

@FranckRJ FranckRJ merged commit 744230d into eranpeer:dev-2.3.1 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants