Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake support. #192

Merged
merged 4 commits into from
Apr 1, 2023
Merged

Conversation

libenike
Copy link
Contributor

Replace old CMakeLists.txt with the new one.
Now FakeIt can be linked to the project in the following way:

find_package(FakeIt)
...
target_link_libraries(a_project
    PRIVATE
        FakeIt::FakeIt
)

I found a related issue with this request.
Also, I create a repository with a simple project which uses FakeIt and a detailed description of building the project.

Replace old CMakeLists.txt with the new one.
Now FakeIt can be bind to a project with two string by cmake:
find_package(FakeIt)
...
target_link_libraries(a_project
    PRIVATE
        FakeIt::FakeIt
)
@libenike libenike mentioned this pull request Nov 12, 2019
@coveralls
Copy link

coveralls commented Nov 12, 2019

Coverage Status

Coverage remained the same at 99.923% when pulling 08d41c6 on libenike:feature/add_cmake_support into 317419c on eranpeer:master.

@aboseley
Copy link

Whats the status of this pull request?

@libenike
Copy link
Contributor Author

Whats the status of this pull request?

The status is open. I am waiting for any response from contributors. You are welcome to leave any suggestions about my fork.

@aboseley
Copy link

aboseley commented Jul 4, 2021

@libenike , your branch works for me, I'd like to see this merged to master.

@FranckRJ FranckRJ added this to the 2.1.0 milestone Jul 5, 2021
@FranckRJ FranckRJ modified the milestones: 2.1.0, 2.2.0 Mar 13, 2022
@FranckRJ
Copy link
Collaborator

FranckRJ commented May 3, 2022

I've thought about it, wouldn't it be better to have one target per configuration? With explicit names I guess, so no "FakeIt::FakeIt" but instead "FakeIt::standalone" or something like that.

@FranckRJ FranckRJ modified the milestones: 2.2.0, 2.3.0 May 8, 2022
@FranckRJ FranckRJ modified the milestones: 2.3.0, 2.4.0 Jun 12, 2022
@FranckRJ FranckRJ changed the base branch from master to dev-2.4.0 December 2, 2022 14:47
@FranckRJ FranckRJ merged commit 33a2bf6 into eranpeer:dev Apr 1, 2023
@FranckRJ
Copy link
Collaborator

FranckRJ commented Apr 1, 2023

I've updated some things in this PR: #311

I removed the target FakeIt::FakeIt, it was replaced by FakeIt::FakeIt-standalone and there's one target per configurations. I guess it's better to install everything even if it makes names a bit more complicated, but maybe we can add a "default configuration" option which will create a target FakeIt::FakeIt to keep the name clean. I don't know yet, it can always be added latter anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants