Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-1922 Revert dotnet format back to CI #2139

Merged
merged 2 commits into from
Nov 22, 2023
Merged

FIX-1922 Revert dotnet format back to CI #2139

merged 2 commits into from
Nov 22, 2023

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Nov 22, 2023 •
edited
Loading

Fixes

This pull request fixes #1922

Description

As the mentioned issue was fixed in SDK 7.0.304, it should be safe to bring back dotnet format to the CI.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

janmarius
janmarius approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@eliasbruvik eliasbruvik merged commit 4fb0fa8 into equinor:main Nov 22, 2023
1 check passed
@eliasbruvik eliasbruvik deleted the FIX-1922-format branch November 22, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmarius janmarius janmarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert dotnet format into CI
2 participants
@eliasbruvik @janmarius