Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2009 Update logCurveInfo properties #2129

Merged

Conversation

jaroslavbliznak
Copy link
Contributor

@jaroslavbliznak jaroslavbliznak commented Nov 13, 2023

Fixes

This pull request fixes #2009

Description

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added suggestions and comments on minor issues. During testing, I also noticed changing the index curve was possible. Is this expected behavior?

@jaroslavbliznak
Copy link
Contributor Author

I have fixed the modification if it is the index curve. In this case, it is not possible to rename the mnemonic.

Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unable to change the name of the mnemonic (error shown in image below). Additionally, it is still possible to modify the unit of the index curve. Should this be allowed?

image

@jaroslavbliznak
Copy link
Contributor Author

This is an error with overlapping indexes during editing, and it only occurs on the test server for Petrolink (https://eqwitsml.demo.petrolink.net/Petrovault/WITSML/WMLS.asmx). Asbjørn has already reported a message about it to them. It should work fine on other servers. The unit should be editable for the index curve as well.

Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@jaroslavbliznak jaroslavbliznak merged commit 8b0dec0 into equinor:main Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User story: Frontend - Update logCurveInfo attributes in property window
2 participants