-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-2009 Update logCurveInfo properties #2129
FIX-2009 Update logCurveInfo properties #2129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added suggestions and comments on minor issues. During testing, I also noticed changing the index curve was possible. Is this expected behavior?
Tests/WitsmlExplorer.IntegrationTests/Api/Workers/RenameMnemonicWorkerTests.cs
Show resolved
Hide resolved
Src/WitsmlExplorer.Api/Workers/Modify/ModifyLogCurveInfoWorker.cs
Outdated
Show resolved
Hide resolved
Src/WitsmlExplorer.Api/Workers/Modify/ModifyLogCurveInfoWorker.cs
Outdated
Show resolved
Hide resolved
Src/WitsmlExplorer.Api/Workers/Modify/ModifyLogCurveInfoWorker.cs
Outdated
Show resolved
Hide resolved
Tests/WitsmlExplorer.Api.Tests/Workers/ModifyLogCurveInfoWorkerTests.cs
Outdated
Show resolved
Hide resolved
Tests/WitsmlExplorer.Api.Tests/Workers/ModifyLogCurveInfoWorkerTests.cs
Outdated
Show resolved
Hide resolved
Src/WitsmlExplorer.Frontend/components/Modals/LogCurveInfoPropertiesModal.tsx
Outdated
Show resolved
Hide resolved
I have fixed the modification if it is the index curve. In this case, it is not possible to rename the mnemonic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an error with overlapping indexes during editing, and it only occurs on the test server for Petrolink (https://eqwitsml.demo.petrolink.net/Petrovault/WITSML/WMLS.asmx). Asbjørn has already reported a message about it to them. It should work fine on other servers. The unit should be editable for the index curve as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer checklist
- Read issue and PR
- Pulled branch and manually tested
- Verify that PR resolves issue
- Reviewed the code
Fixes
This pull request fixes #2009
Description
Type of change
Impacted Areas in Application
Checklist:
Communication
Code quality
Test coverage
Further comments