User defined vector definition in SimulationTimeSeries plugin #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use naming "VectorDefinition" - Adjust to "AVG_" -> "PER_DAY_" and "INTVL_" -> "PER_INTVL_"
…ser-defined-vector-definition
- Update unit tests according to "PER_DAY_" and "PER_INTVL_" notation - Bug fix (missing well name in plot title) - Refactor methods
jorgenherje
added
enhancement 🚀
Add unit test for refactored simulation_vector_description() method in reservoir_simulation.py
Adapted to utilize VectorDefinitions from webviz-subsurface-components Python-API
…ser-defined-vector-definition
Correct changelog - "Added" and "Changed" info Fix typo
jorgenherje
force-pushed
the
EQ_698-user-defined-vector-definition
branch
from
e62008c to
e515856
Compare
- When downloading statistics, .loc gave SettingWithCopyWarning warning.
- Remove usage of .loc as chained index is not needed: ["DATE"] instead of
[("DATE", "")].
- Make copy as download is not performance critical and statistics df
contains less data.
…ser-defined-vector-definition
This was referenced Feb 8, 2022
Closed
anders-kiaer
requested changes
Feb 9, 2022
Co-authored-by: Anders Fredrik Kiær <[email protected]>
Co-authored-by: Anders Fredrik Kiær <[email protected]>
…ser-defined-vector-definition
anders-kiaer
approved these changes
Feb 9, 2022
VincentNevermore
pushed a commit
to VincentNevermore/webviz-subsurface
that referenced
this pull request
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add user defined vector definitions for
SimulationTimeSeries- pluginAVG_andINVTL_toPER_DAY_andPER_INTVL_, respectively. For vector it is calculated fromT-suffix withR-suffix forPER_DAY_-vectorWOPTgaveAVG_WOPRandINTVL_WOPT. Not it givesPER_DAY_WOPTandPER_INTVL_WOPTwebviz_subsurface/_abbreviations/abbreviation_data/reservoir_simulation_vectors.jsonand retrieveVectorDefinitionsusing new in Python-API forwebviz-subsurface-components.NOTE:
Resolves:
Dependent on: