Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes and improvements to ParameterFilter and ParameterAnalysis #924

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Bugfixes and improvements to ParameterFilter and ParameterAnalysis #924

merged 4 commits into from
Jan 20, 2022

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Jan 17, 2022

PR with bugfixes and improvements to the ParameterFilter component and to the ParameterAnalysis plugin

ParameterFilter

Bugfixes:

  • Handle NaN values in parameter dataframe that enters the ParameterFilter. NaN values in the Select component caused issues when trying to render the layout.

Added functionality:

  • Option to choose which ensemble to filter on
  • Option to use range from selected ensemble or from all ensembles
  • Active Filter indicator where the user can see which parameters are active and their ranges
  • Information regarding which realizations are removed with the current filter
  • Apply button changes color when selected filters is not in sync with stored filters

image

ParameterAnalysis

Bugfixes:

  • If only one realization left after filtering the correlation would fail in the ParameterAnalysis
  • remove sensitivity ensembles as options in the Correlation tab
  • fix number formatting in table
  • fix issue with persistence to remember selection also when page is refreshed

Added functionality:

  • boxplot added as option in the parameter distribution tab
  • available parameters in both tabs now updates based on selected ensembles
  • update ensemble in the ParameterFilter when ensemble is changed

@tnatt tnatt requested a review from HansKallekleiv January 17, 2022 15:52
@tnatt tnatt force-pushed the bugfix_parameterfilter branch from fdca397 to b320bba Compare January 17, 2022 17:31
HansKallekleiv
HansKallekleiv reviewed Jan 17, 2022
View reviewed changes
webviz_subsurface/_components/parameter_filter.py Outdated
"id": uuid,
"type": "slider",
"name": name,
"r": str(random.random()), # needed to trigger update (bug)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try uuid4 instead for the security issue

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion, I will 👍

@tnatt tnatt force-pushed the bugfix_parameterfilter branch from b320bba to 8f9fbcd Compare January 17, 2022 20:54
@tnatt tnatt force-pushed the bugfix_parameterfilter branch from 09dad70 to d808ef9 Compare January 18, 2022 11:26
@anders-kiaer anders-kiaer added the next release 🚢 To be included in next release label Jan 19, 2022
@anders-kiaer anders-kiaer merged commit 8cebeb1 into equinor:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansKallekleiv HansKallekleiv HansKallekleiv approved these changes

Assignees
No one assigned
Labels
next release 🚢 To be included in next release
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnatt @HansKallekleiv @anders-kiaer