-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimulationTimeSeries
: Add statistics after realizations
#913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a minor detail regarding comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for new comments
webviz_subsurface/plugins/_simulation_time_series/_callbacks.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jørgen Herje <[email protected]>
Co-authored-by: Jørgen Herje <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - I like it! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
* Dynamic tick marks and labels based on zoom * Dynamic tick marks and labels based on zoom * Made ticsk a bit less dense and removed the decimals Co-authored-by: Håvard Bjerke <[email protected]>
Adds the statistics after the individual realizations rather than before, meaning that the statistics will be placed on top (though only for the given vector/ensemble. Additional vectors/ensembles will still be placed on top). Makes it easier to see statistics when plotting both (note difference in the area to the lower left with very high density of realizations covering all of the statistics).
![image](https://user-images.githubusercontent.com/47146384/148429836-3b3136e0-e94a-49d3-8fa7-3e15a8587a33.png)
Example:
Old behavior:
New behavior:
![image](https://user-images.githubusercontent.com/47146384/148429787-7e0c45e5-75cb-482e-a0ae-2acef6844aa1.png)