Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group tree dataprovider #902

Merged
merged 13 commits into from
Jan 13, 2022
Merged

Group tree dataprovider #902

merged 13 commits into from
Jan 13, 2022

Conversation

lindjoha
Copy link
Collaborator

  • Move to .arrow summary data provider
  • Updated file names and folder structure to best practice

@lindjoha lindjoha self-assigned this Dec 30, 2021
@lindjoha lindjoha force-pushed the group_tree_dataprovider branch from a9d3e52 to 20f016c Compare December 30, 2021 11:42
@anders-kiaer anders-kiaer mentioned this pull request Jan 4, 2022
Closed
11 tasks
@lindjoha lindjoha force-pushed the group_tree_dataprovider branch from f482aa9 to 524073e Compare January 5, 2022 17:39
@lindjoha lindjoha requested review from sigurdp and removed request for sigurdp January 6, 2022 08:56
jorgenherje
jorgenherje approved these changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Ran the plugin in and seems to work well, so just some minor comments regarding syntax.

webviz_subsurface/plugins/_group_tree/_ensemble_group_tree_data.py Outdated Show resolved Hide resolved
tests/unit_tests/plugin_tests/test_grouptree.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_group_tree/_ensemble_group_tree_data.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_group_tree/_callbacks.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_group_tree/_callbacks.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_group_tree/_ensemble_group_tree_data.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_group_tree/_plugin.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_group_tree/_plugin.py Outdated Show resolved Hide resolved
webviz_subsurface/plugins/_group_tree/_plugin.py Outdated Show resolved Hide resolved
jorgenherje
jorgenherje requested changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct from approved to request change

@jorgenherje jorgenherje self-requested a review January 13, 2022 09:16
jorgenherje
jorgenherje requested changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, otherwise all looks good! 👍

webviz_subsurface/plugins/_group_tree/_ensemble_group_tree_data.py Outdated Show resolved Hide resolved
@lindjoha lindjoha force-pushed the group_tree_dataprovider branch from c325a1d to e54ffbe Compare January 13, 2022 11:46
jorgenherje
jorgenherje approved these changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lindjoha lindjoha merged commit 8f5e0e7 into equinor:master Jan 13, 2022
@lindjoha lindjoha deleted the group_tree_dataprovider branch January 28, 2022 14:43
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
@shadab-skhan
Typecheck error in DeckGlMap (equinor#902)
f62e216 
* Typecheck error in DeckGlMap

* Scroller.tsx children missing prop-type validation

* add dispatch to useEffect dependency list

* Moved store update on layer change from DeckGLMap to Map

Co-authored-by: Shadab Khan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgenherje jorgenherje jorgenherje approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

@sigurdp sigurdp Awaiting requested review from sigurdp

Assignees

@lindjoha lindjoha

Labels
None yet
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindjoha @jorgenherje