Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements to VolumetricAnalysis #895

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Dec 20, 2021

Several improvements to VolumetricAnalysis, some based on of user-feedback.

Main changes Inplace distributions tab

  • Merged functionality in pages 1 plot/1 table and Custom plotting, in order to make it less confusing for the users what page to use, and also simplify the code logic. The only real difference between the two pages was that the user could make subplots in the Custom plotting. This is still available, and an option to hide the table below is added to make more space for the subplots.
  • Added useful "colorby" feature to the barplots in Plots per zone/region page. If colorby is selected the piechart is hidden.
  • Change to returning entire layout for the pages, instead of individual figures --> if a selection/filter changes all plots needs to be updated anyway. This helps improving the readability of the code and reduces a lot of code lines.
  • Remove "REAL" as colorby option for plot types other than "scatter"
  • Remove the fluid annotation automatically if the x-response is a HC-response
  • Added shading to Convergence plots to indicate missing realizations, and added more explanatory hoverinfo.

Other general changes

  • Adjust heights of different views to remove overflow
  • Comparions tab: extend x-axis range by 10% to fix formatting issue when only one data point, and add dotted lines indicating the "highlight threshold" for all plots with difference in percent on the y-axis
  • Tornado tab: removed confusing "casetype" in hover for the "realization plot"
  • Only calculate "NTG" and "PORO_NET" columns if "NET" varies from "BULK"

image

image

@tnatt tnatt requested a review from HansKallekleiv December 20, 2021 14:13
@tnatt tnatt self-assigned this Dec 20, 2021
@tnatt
Copy link
Collaborator Author

tnatt commented Dec 20, 2021

Will add changelog tomorrow 🙂

@anders-kiaer anders-kiaer added enhancement 🚀 New feature or request next release 🚢 To be included in next release labels Dec 21, 2021
Copy link
Collaborator

@HansKallekleiv HansKallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Approved after changelog is added.

@tnatt tnatt force-pushed the add-parameters-to-tables branch from 98dcfc1 to a2d52dd Compare December 21, 2021 11:53
@tnatt tnatt force-pushed the add-parameters-to-tables branch from a2d52dd to 15676cc Compare December 22, 2021 09:18
@tnatt tnatt requested a review from HansKallekleiv December 22, 2021 09:18
@tnatt tnatt merged commit 91cdd14 into equinor:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request next release 🚢 To be included in next release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants