Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter response tab in RFT plotter #884

Merged
merged 42 commits into from
Dec 21, 2021

Conversation

lindjoha
Copy link
Collaborator

Included a new tab with plots for analysing the RFT response to parameters:

  • bar chart with correlations. Option to select RFT vs parameters or parameter vs RFTs.
  • scatter plot with RFT vs parameter. Vertical lines showing the observation with errors
  • formations plot colored by parameter.

The functionality is inspired by the Parameter Analysis plugin and some of the functionality is generalized. Some of the figures (bar chart and scatter plot) are prepared for further generalization between the two.

The parameter response tab will not appear when working with aggregated data. Or when for some reason no non-constant parameters are found.

@anders-kiaer anders-kiaer added the next release 🚢 To be included in next release label Dec 15, 2021
@lindjoha lindjoha force-pushed the rftplotter_new_functionality branch from 452e574 to 90f5e5a Compare December 17, 2021 13:52
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR @lindjoha! 🚀 Worth a changelog entry?

webviz_subsurface/_figures/barchart.py Show resolved Hide resolved
webviz_subsurface/_utils/colors.py Outdated Show resolved Hide resolved
webviz_subsurface/_utils/colors.py Show resolved Hide resolved
@lindjoha lindjoha force-pushed the rftplotter_new_functionality branch from 90f5e5a to 755042c Compare December 17, 2021 15:14
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the modifications 👍

@lindjoha lindjoha merged commit ed92862 into equinor:master Dec 21, 2021
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release 🚢 To be included in next release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants