Allow mixing sensitivity and gen_kw ensembles in ParametersModel
#855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnatt
requested review from
anders-kiaer,
asnyv and
HansKallekleiv
as code owners
tnatt
force-pushed
the
support-both-ensembletypes
branch
from
be7b1c0 to
75ad9da
Compare
Originally I just removed the Error, but than I thought we might have plugins were it might be important to only have one.. but thinking about it again, as long as we provide sensitivity columns to non-sensitivity ensembles it should not be a problem to include them in any plugin :) I'll clean up the PR and remove that option.. can rather put it back in if ever needed 👍 |
tnatt
force-pushed
the
support-both-ensembletypes
branch
from
53b6d72 to
8560435
Compare
VincentNevermore
pushed a commit
to VincentNevermore/webviz-subsurface
that referenced
this pull request
Jul 19, 2022
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Håvard Bjerke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to support a mix of sensitivity ensembles and gen_kw ensembles in
ParametersModel.A dice is added as SENSNAME to gen_kw ensembles for easy distinction from sensitivity ensembles: