Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct inline/xline ranges for axes in SegyViewer z-slice graph #765

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Use correct inline/xline ranges for axes in SegyViewer z-slice graph #765

merged 4 commits into from
Sep 15, 2021

Conversation

ashildskalnes
Copy link
Contributor

@ashildskalnes ashildskalnes commented Sep 13, 2021 •
edited
Loading

This is a small fix to make sure that the z-slice is displayed at the correct position independent of the range of inlines and crosslines

Contributor checklist

  • 🎉 This PR closes Depth slice in the SEG-Y viewer might be displayed wrongly #764.
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@anders-kiaer
Copy link
Collaborator

anders-kiaer commented Sep 13, 2021 •
edited
Loading

Nice @ashildskalnes 🥳 - this looks good to me. Could you add a new entry in CHANGELOG.md before we merge this? I.e. add a new Fixed section under [UNRELEASED] here: https://github.com/equinor/webviz-subsurface/blob/master/CHANGELOG.md#unreleased---yyyy-mm-dd

@HansKallekleiv HansKallekleiv changed the title Surface viewer Use correct inline/xline ranges for axes in SegyViewer z-slice graph Sep 13, 2021
@anders-kiaer anders-kiaer mentioned this pull request Sep 14, 2021
Closed
6 tasks
@anders-kiaer anders-kiaer added the next release 🚢 To be included in next release label Sep 14, 2021
anders-kiaer
anders-kiaer approved these changes Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anders-kiaer anders-kiaer merged commit 1257f54 into equinor:master Sep 15, 2021
@ashildskalnes ashildskalnes deleted the surface_viewer branch September 15, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@asnyv asnyv Awaiting requested review from asnyv

@HansKallekleiv HansKallekleiv Awaiting requested review from HansKallekleiv

@tnatt tnatt Awaiting requested review from tnatt

Assignees

@ashildskalnes ashildskalnes

Labels
next release 🚢 To be included in next release
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depth slice in the SEG-Y viewer might be displayed wrongly
2 participants
@ashildskalnes @anders-kiaer