Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Dash version to 2.0 #760

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Conversation

HansKallekleiv
Copy link
Collaborator

  • 📜 I have broken down my PR into the following tasks:
    • Bump Dash dependency to 2.0
    • Simplify import statement as suggested in Dash 2.0 migration
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 🚀

import dash_html_components as html
from dash.dependencies import Input, Output, State
from webviz_config.themes import default_theme
from webviz_config import WebvizSettings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these were unused? Strange that pylint haven't captured it before? 🤔

@HansKallekleiv HansKallekleiv merged commit 617f717 into equinor:master Sep 13, 2021
@HansKallekleiv HansKallekleiv deleted the dash-2.0.0 branch September 13, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance next release 🚢 To be included in next release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants