Handle missing surfaces in PropertyStatistics and support changes in input format #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKallekleiv
requested review from
anders-kiaer,
asnyv and
tnatt
as code owners
HansKallekleiv
force-pushed
the
fix-missing-surfaces-propstats
branch
from
9a71afa to
c38d742
Compare
tnatt
approved these changes
Aug 31, 2021
| ) | ||
| except ValueError: # Surface does not exist | ||
| return ( | ||
| dash.dash.no_update, |
There was a problem hiding this comment.
Consider changing to dash.no_update instead?
HansKallekleiv
force-pushed
the
fix-missing-surfaces-propstats
branch
from
c38d742 to
1f05ecc
Compare
tnatt
reviewed
Sep 1, 2021
| if TYPE_CHECKING: | ||
| # pylint: disable=cyclic-import | ||
| from ..property_statistics import PropertyStatistics | ||
| from ..models import PropertyStatisticsModel |
There was a problem hiding this comment.
Looks like you are importing the PropertyStatisticsModel twice
tnatt
reviewed
Sep 1, 2021
Comment on lines
6
to
13
| from webviz_subsurface.plugins._property_statistics.models.property_statistics_model import ( | ||
| PropertyStatisticsModel, | ||
| ) | ||
| from .selector_view import ( | ||
| ensemble_selector, | ||
| property_selector, | ||
| filter_selector, | ||
| source_selector, | ||
| ) | ||
|
|
||
| if TYPE_CHECKING: | ||
| # pylint: disable=cyclic-import | ||
| from ..property_statistics import PropertyStatistics | ||
| from ..models import PropertyStatisticsModel |
HansKallekleiv
force-pushed
the
fix-missing-surfaces-propstats
branch
from
6a53a0a to
cc4aff9
Compare
VincentNevermore
pushed a commit
to VincentNevermore/webviz-subsurface
that referenced
this pull request
Jul 19, 2022
* well completions viewer component test * well completions performance test * merge master branch and format * undo formatting of vector components * update failing snapshots * fix failing snapshots test Co-authored-by: Håvard Bjerke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
PropertyStatistics#752.Countcolumn from the input data if existing.CHANGELOG.md, and added it if should be communicated there.