Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix in VolumetricAnalysis to trigger callbacks on page refresh #748

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Bugfix in VolumetricAnalysis to trigger callbacks on page refresh #748

merged 1 commit into from
Aug 31, 2021

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Aug 30, 2021

Bugfix VolumetricAnalysis to trigger callbacks on a page-refresh.

  • Memory storage using dcc.Store has been added to keep track of which pages has been initially loaded after a page refresh. This info is in turn used to trigger the necessary callbacks for displaying data.
  • Also removed two unused dcc.Store variables

@tnatt tnatt requested a review from HansKallekleiv August 30, 2021 13:18
anders-kiaer
anders-kiaer approved these changes Aug 31, 2021
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog entry regarding the fix?

@anders-kiaer anders-kiaer added the next release 🚢 To be included in next release label Aug 31, 2021
@tnatt
Copy link
Collaborator Author

tnatt commented Aug 31, 2021

Add changelog entry regarding the fix?

I forgot to mention, it is a bugfix on a bug not yet released. It was introduced in #724. Should I still put in an entry?

@anders-kiaer
Copy link
Collaborator

I forgot to mention, it is a bugfix on a bug not yet released. It was introduced in #724. Should I still put in an entry?

Then never mind my comment 🙂 Let's merge.

@anders-kiaer anders-kiaer merged commit b12c3d1 into equinor:master Aug 31, 2021
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
@shadab-skhan
Storybook for multiple synced and 3d view (equinor#748)
d7a6ba9 
* Storybook example for multiple synced views

* storybook for 3d view

Co-authored-by: Shadab Khan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

@HansKallekleiv HansKallekleiv Awaiting requested review from HansKallekleiv

@asnyv asnyv Awaiting requested review from asnyv

Assignees

@tnatt tnatt

Labels
next release 🚢 To be included in next release
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnatt @anders-kiaer