-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector Calculator in Reservoir Simulation Timeseries plugin #709
Merged
jorgenherje
merged 25 commits into
equinor:master
from
CeetronSolutions:EQ_293-VectorCalculatorReactComponent
Sep 21, 2021
Merged
Vector Calculator in Reservoir Simulation Timeseries plugin #709
jorgenherje
merged 25 commits into
equinor:master
from
CeetronSolutions:EQ_293-VectorCalculatorReactComponent
Sep 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asnyv
reviewed
Aug 25, 2021
asnyv
reviewed
Aug 25, 2021
asnyv
reviewed
Aug 26, 2021
asnyv
reviewed
Aug 26, 2021
jorgenherje
force-pushed
the
EQ_293-VectorCalculatorReactComponent
branch
2 times, most recently
from
September 17, 2021 11:36
3fb2afb
to
6bbd622
Compare
asnyv
reviewed
Sep 21, 2021
asnyv
reviewed
Sep 21, 2021
Add vector calculator react component into reservoir simulation time series - Retrieve predefined expressions for vector calculator from config file - Utility functions for handling expressions and calculation of resulting vectors
Assign empty list to current child list if list does not exist to prevent NoneType - which is not iterable.
- Update utility function with np.ndarray according to update of VectorCalculator.evaluate_expression() update. - Remove unused/incorrect imports - Minor fix of documentation and linting
Move calculation of vector calculator expressions into calculate_vector_dataframes and prevent copy of smry in large scale. Filter as much data as possible prior to calculation.
Neglect order of variables in expression string and variables in map from configured predefined expressions when validating
Description is an optional feature.
Added utility function for converting list of vector calculator expressions to custom vector definitions type for vector selector.
Useless suppression of 'ungrouped-imports'
Add vector calculator expressions as custom vector definitions for vector selector
Check if "predefined_expressions" string is present in webviz_settings.shared_setting dict
- Moved utility functions for vector selector into utility file in _utils folder.
jorgenherje
force-pushed
the
EQ_293-VectorCalculatorReactComponent
branch
from
September 21, 2021 12:37
5553d92
to
2588e3a
Compare
anders-kiaer
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo in changelog, other than that this looks good to go to me. ⛵
VincentNevermore
pushed a commit
to VincentNevermore/webviz-subsurface
that referenced
this pull request
Jul 19, 2022
* First working version. * Test/fix + lint and typecheck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added usage of the vector calculator react component in reservoir simulation timeseries Dash plugin
Dependent on:
Closes issue: Closes issue #293
Functionality