Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector Calculator in Reservoir Simulation Timeseries plugin #709

Conversation

jorgenherje
Copy link
Collaborator

@jorgenherje jorgenherje commented Jul 2, 2021

Added usage of the vector calculator react component in reservoir simulation timeseries Dash plugin

Dependent on:

Closes issue: Closes issue #293


Functionality

  • Add new expression
  • Delete expressions
  • Clone expressions
  • Edit expressions
  • Plot expressions

@jorgenherje jorgenherje requested a review from tnatt as a code owner August 25, 2021 12:20
@jorgenherje jorgenherje force-pushed the EQ_293-VectorCalculatorReactComponent branch 2 times, most recently from 3fb2afb to 6bbd622 Compare September 17, 2021 11:36
@anders-kiaer anders-kiaer added the next release 🚢 To be included in next release label Sep 20, 2021
webviz_subsurface/_utils/vector_calculator.py Outdated Show resolved Hide resolved
webviz_subsurface/_utils/vector_calculator.py Outdated Show resolved Hide resolved
webviz_subsurface/_utils/vector_calculator.py Outdated Show resolved Hide resolved
webviz_subsurface/_utils/vector_calculator.py Outdated Show resolved Hide resolved
webviz_subsurface/_utils/vector_calculator.py Outdated Show resolved Hide resolved
webviz_subsurface/_utils/vector_calculator.py Outdated Show resolved Hide resolved
jorgenherje and others added 12 commits September 21, 2021 14:34
Add vector calculator react component into reservoir simulation time series

- Retrieve predefined expressions for vector calculator from config file
- Utility functions for handling expressions and calculation of resulting vectors
Assign empty list to current child list if list does not exist to
prevent NoneType - which is not iterable.
- Update utility function with np.ndarray according to update of
VectorCalculator.evaluate_expression() update.
- Remove unused/incorrect imports
- Minor fix of documentation and linting
Move calculation of vector calculator expressions into
calculate_vector_dataframes and prevent copy of smry in large scale.
Filter as much data as possible prior to calculation.
Neglect order of variables in expression string and variables in
map from configured predefined expressions when validating
Description is an optional feature.
Added utility function for converting list of vector calculator
expressions to custom vector definitions type for vector
selector.
Useless suppression of 'ungrouped-imports'
Add vector calculator expressions as custom vector definitions for
vector selector
Check if "predefined_expressions" string is present in
webviz_settings.shared_setting dict
- Moved utility functions for vector selector into utility file in _utils folder.
@jorgenherje jorgenherje force-pushed the EQ_293-VectorCalculatorReactComponent branch from 5553d92 to 2588e3a Compare September 21, 2021 12:37
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in changelog, other than that this looks good to go to me. ⛵

@jorgenherje jorgenherje merged commit b747851 into equinor:master Sep 21, 2021
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
* First working version.

* Test/fix + lint and typecheck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release 🚢 To be included in next release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants