Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for cross-section plugins #618

Merged

Conversation

HansKallekleiv
Copy link
Collaborator

@HansKallekleiv HansKallekleiv commented Apr 27, 2021

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.


Contributor checklist

  • 🎉 This PR relates to Deprecate cross-section plugins #617
  • 📜 I have broken down my PR into the following tasks:
    • Add deprecation warning to HorizonUncertaintyViewer, WellCrossSection, WellCrossSectionFMU.
    • Update webviz-config dependency
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@HansKallekleiv HansKallekleiv force-pushed the deprecate-cross-sections branch 5 times, most recently from 7667b91 to 0fd736e Compare April 27, 2021 15:45
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple of minor comments only - then we can merge this.

@HansKallekleiv HansKallekleiv force-pushed the deprecate-cross-sections branch 3 times, most recently from d6fc0e8 to e70e7a3 Compare April 29, 2021 14:12
@HansKallekleiv HansKallekleiv force-pushed the deprecate-cross-sections branch from e70e7a3 to 140322a Compare April 29, 2021 14:13
@anders-kiaer anders-kiaer merged commit 23e852e into equinor:master Apr 29, 2021
@anders-kiaer anders-kiaer mentioned this pull request Jun 28, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants