Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot options ReservoirSimulationTimeSeries #612

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

asnyv
Copy link
Collaborator

@asnyv asnyv commented Apr 23, 2021

Modifications to ReservoirSimulationTimeseries:

  • Allow statistical lines without fill (including new P50/median). (Easier to read, avoids overlapping color fills)
    • Can choose which statistics to include (Mean, P10, P50, P90, Max, Min)
  • Option to remove history trace (and cut history trace at current date, as longer is not realistic even though Eclipse creates it)
  • Add legendgroup to histogram traces to make them "toggleable"
  • Allow histogram together with individual realizations
  • Remove history traces in delta plots

Technically breaking: statistics_hist no longer valid config option (but doubt it is used at all). The default statistics now refers to statistical lines, whilst fanchart refers to the old default. May consider to change the default to fanchart, but I think at least the naming is most descriptive this way.

Contributor checklist

@asnyv asnyv changed the title Ts plots Plot options ReservoirSimulationTimeSeries Apr 23, 2021
@asnyv asnyv mentioned this pull request Apr 23, 2021
6 tasks
@asnyv asnyv force-pushed the ts_plots branch 2 times, most recently from 307852e to 1142f55 Compare April 26, 2021 13:36
@asnyv asnyv marked this pull request as ready for review April 26, 2021 14:10
Copy link
Collaborator

@HansKallekleiv HansKallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@asnyv asnyv merged commit 0816911 into equinor:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants